Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reserving executable memory as per allocation type in ClrVirtualAllocWithinRange() #83819

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix reserving executable memory as per allocation type in ClrVirtualAllocWithinRange() #83819

merged 1 commit into from
Mar 24, 2023

Conversation

k15tfu
Copy link
Contributor

@k15tfu k15tfu commented Mar 23, 2023

Fixes #83818

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 23, 2023
@k15tfu k15tfu mentioned this pull request Mar 23, 2023
Closed
janvorli
janvorli reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding. It seems we have never discovered that as this means that all the preallocated memory from the executable allocator must be depleted before we hit this code path.

src/coreclr/utilcode/util.cpp Outdated Show resolved Hide resolved
janvorli
janvorli approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit b61b5a2 into dotnet:main Mar 24, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 24, 2023
Closed
@k15tfu k15tfu deleted the fix-issue-83818 branch March 25, 2023 05:45
@k15tfu
Copy link
Contributor Author

k15tfu commented Mar 25, 2023

@janvorli Thank you!

Would it be possible to backport this to 7.0?

@janvorli
Copy link
Member

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4530309491

@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
@janvorli
Copy link
Member

@k15tfu I've created a porting PR and waiting for approval.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.OutOfMemoryException when allocating jump stub on macOS ARM64
2 participants
@k15tfu @janvorli