Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimally light up Quaternion and Plane for Mono SIMD #81541

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Minimally light up Quaternion and Plane for Mono SIMD #81541

merged 2 commits into from
Feb 8, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Feb 2, 2023 •
edited by fanyang-mono
Loading

Fixes #81483

@ghost ghost assigned tannergooding Feb 2, 2023
@tannergooding tannergooding force-pushed the numerics-rewrite branch 3 times, most recently from e43eb21 to a7a817e Compare February 2, 2023 17:05
@runfoapp runfoapp bot mentioned this pull request Feb 2, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 4, 2023
Closed
@tannergooding tannergooding force-pushed the numerics-rewrite branch 6 times, most recently from db6f11b to 6b031ea Compare February 6, 2023 15:57
@tannergooding tannergooding force-pushed the numerics-rewrite branch 4 times, most recently from 5d8d773 to f0adadc Compare February 7, 2023 20:55
@tannergooding tannergooding changed the title Try to minimally light up Vector2, Vector3, Quaternion, and Plane for Mono SIMD Minimally light up Quaternion and Plane for Mono SIMD Feb 7, 2023
@tannergooding
Copy link
Member Author

Talked with @fanyang-mono a bit more.

Going to split this into at least 3 total PRs:

  • This one, which adds Quaternion/Plane giving parity with the existing Vector4 support
  • One that ensures new intrinsics, such as SN_Length, are handled
  • One that adds support for Vector2/Vector3, since those require more in depth work

@tannergooding tannergooding marked this pull request as ready for review February 7, 2023 20:57
This was referenced Feb 8, 2023
Closed
Closed
fanyang-mono
fanyang-mono approved these changes Feb 8, 2023
View reviewed changes
src/mono/mono/mini/simd-intrinsics.c Show resolved Hide resolved
src/mono/mono/mini/simd-intrinsics.c Show resolved Hide resolved
@fanyang-mono
Copy link
Member

Thanks for adding intrinsics support of Quaternion and Plane for Mono.

@tannergooding tannergooding mentioned this pull request Feb 8, 2023
Closed
@fanyang-mono
Copy link
Member

Failures on runtime (Build browser-wasm windows Release Mono_DebuggerTests_chrome) is not related to this PR. It is a know issue #81792

@fanyang-mono fanyang-mono merged commit 82d187a into dotnet:main Feb 8, 2023
@tannergooding tannergooding deleted the numerics-rewrite branch February 8, 2023 22:26
@tannergooding
Copy link
Member Author

Improvements:

@tannergooding tannergooding mentioned this pull request Feb 14, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@tannergooding tannergooding

Labels
area-Codegen-LLVM-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mono] Intrinsify Quaternion and Plane with LLVM as backend
2 participants
@tannergooding @fanyang-mono