-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Target lower glibc for Linux arm64 #80866
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis uses new cross-build images, added in dotnet/dotnet-buildtools-prereqs-docker#754, that target Ubuntu 16.04. It should address the .NET 7 part of #69361. The new images were published here: dotnet/versions@33968c3
|
This reverts commit 8fee6ff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 7.0.x. please get a code review
Since this PR hit the failure due to not finding the ARM64 helix queue, I'm closing and reopening it now that I merged the fixes for those queues, to ensure we get the necessary coverage in the PR. |
This uses new cross-build images, added in dotnet/dotnet-buildtools-prereqs-docker#754, that target Ubuntu 16.04. It should address the .NET 7 part of #69361.
Same change was made in .NET 8 here: #80939.
The new images were published here: dotnet/versions@33968c3Updated to dotnet/versions@f2e8ed1.
Customer Impact
Allows .NET Linux arm64 to run on Amazon Linux 2 by lowering the glibc version requirement to 2.23. Fixes the .NET 7 part of #69361. Customers were hitting the following when using .NET Linux arm64 for AWS Lambda functions:
AWS tracking issue: aws/aws-lambda-dotnet#1310
Testing
Risk
Low to medium. Any risk is limited to Linux arm64. This is a change in the version of a fundamental dependency, but testing gives confidence that the fix is functionally good. Building with PGO instrumentation has been validated. Collection of PGO data, and validation of the perf characteristics of PGO-optimized builds using the resulting data, has not been manually tested, but the fix has gone through the .NET 8 official build process successfully, suggesting that it passes any automated PGO validation we have.