Avoid duplicated read #77577
Merged
Avoid duplicated read #77577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
mangod9
approved these changes
Oct 31, 2022
|
I verified that the after disssambly is not doing the double loading. it gets the address in 0:023> u 5f1dbb7c
coreclr!WKS::gc_heap::revisit_written_page+0x20c [C:\runtime-segments\src\coreclr\gc\gc.cpp @ 35620]:
5f1dbb7c 8b12 mov edx,dword ptr [edx]
5f1dbb7e 8975fc mov dword ptr [ebp-4],esi
5f1dbb81 ff00 inc dword ptr [eax]
5f1dbb83 3b1554a74f5f cmp edx,dword ptr [coreclr!WKS::gc_heap::background_saved_lowest_address (5f4fa754)]
5f1dbb89 0f82be000000 jb coreclr!WKS::gc_heap::revisit_written_page+0x2dd (5f1dbc4d)
5f1dbb8f 8975fc mov dword ptr [ebp-4],esi
5f1dbb92 3b1550a74f5f cmp edx,dword ptr [coreclr!WKS::gc_heap::background_saved_highest_address (5f4fa750)]
5f1dbb98 0f83af000000 jae coreclr!WKS::gc_heap::revisit_written_page+0x2dd (5f1dbc4d)
0:023> u
coreclr!WKS::gc_heap::mark_array_marked [C:\runtime-segments\src\coreclr\gc\gc.cpp @ 35620] [inlined in coreclr!WKS::gc_heap::revisit_written_page+0x22e [C:\runtime-segments\src\coreclr\gc\gc.cpp @ 35620]]:
5f1dbb9e a12ca74f5f mov eax,dword ptr [coreclr!WKS::gc_heap::mark_array (5f4fa72c)]
5f1dbba3 8bca mov ecx,edx
5f1dbba5 c1e908 shr ecx,8 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed the issue that we have a duplicate read found in #77087.