-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ComInterfaceGenerator.Unit.Tests for NativeAOT #77522
Conversation
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
I'm also blocking ComInterfaceGenerator.Tests because DNNE doesn't work. Cc @dotnet/interop-contrib - we won't have any NativeAOT coverage for this unless a non-DNNE fallback is added.
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
I don't understand why DNNE doesn't work in this case. If the test is NativeAOT, DNNE should be able to load an instance of the runtime and carry on. Is understanding why that is failing in NativeAOT the issue? |
I didn't debug this but how does dnne find a CoreCLR runtime if there's no runtime loaded in the process? |
It uses the normal .NET hosting look up. In this case it uses the dropped |
I don't think we have a globally installed .NET runtime when doing NativeAOT testing. Helix machines are unlikely to have it and we don't send anything in the payload either because we're testing NativeAOT. |
I see. What we might want to do then NativeAOT these assets instead of using DNNE for the NativeAOT scenario. This way we would get additional testing and since DNNE uses the same export tech as NativeAOT, I think it should just work. |
Fixes #77476.
The project is set up in an odd way and we miss a reference. This happens in a spot that is hard to be proactive about: the missing type is a generic argument and that's annoying to check for because it could lead to recursions that we're not ready to handle - e.g.
class Foo : IComparable<Foo>
. We could fix that, but also the detection of broken inputs has its limits.Also, building a test that references Roslyn takes forever and source generator tests are unlikely to find runtime issues so I'm 100% comfortable not running this test ever.
Cc @dotnet/ilc-contrib