[wasm][debugger] Remove non-deterministic signals from debugger tests. #77038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsFixes #75392.
|
radical
reviewed
Oct 19, 2022
radical
approved these changes
Oct 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75392.
Removes
Task.DelayandThread.Sleepfrom debugger tests.ExceptionTestUncaughtWithReload- usingApp_Readyis enough.CreateGoodBreakpointAndHitGoToNonWasmPageComeBackAndHitAgain: we are going to non-wasm page, so there's no runtime from which we could get info about being ready. Also, we cannot rely on any message passed from browser to notify the inspector in all cases because it would send notification for wasm as well. That's why we introduce a new mechanism of informing Inspector that tests are waiting for non-wasm loading and only then we can notify about runtime context being created.ExceptionTestAllWithReloadhad a Sleep that was in fact useless asSendCommandAndCheckwaits forInspector.PAUSEevant by default anyway.