Enable visual styles for host error dialog via activation context #76762
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsEmbed a manifest into This is just creating an activation context using the manifest, not trying to show a win32 task dialog yet. This is a prerequisite for using the task dialog though. This is +1kB to Before: After: Contributes to #71288. cc @richlander
|
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | |||
There was a problem hiding this comment.
Would it also be possible to set the default DPI awareness in the manifest, like this:
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | |
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"> | |
| <asmv3:application> | |
| <asmv3:windowsSettings> | |
| <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true/pm</dpiAware> | |
| <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2,PerMonitor</dpiAwareness> | |
| </asmv3:windowsSettings> | |
| </asmv3:application> | |
It will prevent the dialog box from being blurry on high DPI monitors (like it is in the image in the PR description). There aren't any code changes required since MessageBox (and Task Dialog) knows how to scale itself when the proper DPI mode is selected. (The specific set of options here makes it compatible with all of the legacy high DPI modes in Windows 7 and 8.x.)
There was a problem hiding this comment.
Unfortunately, that seems to be one of those settings that has to be in the process manifest and doesn't work with programmatically creating/activating a context.
It might be worth looking into what we can do and what it would cost though. I did see the APIs available starting with one of the Win10 updates that allow controlling DPI awareness for the thread, but I'd rather keep investigating that separate from getting a manifest / activation context in for modern theming.
There was a problem hiding this comment.
Oh—that's too bad. I see now from the docs that the activation context only holds the SxS information. I am sorry, I should have tried with the activation context before suggesting this.
There was a problem hiding this comment.
I think it's a great suggestion, and it's unfortunate it doesn't work the simple way. I agree that we should investigate the APIs a separate work item - if nothing else it would need some light-up code and so on.
Make
apphoston Windows enable visual styles using the WindowsShell manifest such that a modern-themed dialog can be shown for runtime/framework not found errors in GUI applications.This is just creating an activation context using the manifest, not trying to show a win32 task dialog yet. This is a prerequisite for using the task dialog though.
Before:
After:
Contributes to #71288.
cc @richlander