-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a WKS specific issue by not clobbering the heap_segment_saved_allocated #72923
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsFor WKS, we weren't using the correct The fix, specifically for WKS, involves not overwriting the value of This PR is an effort to fix microbenchmarks that regressed after regions were introduced such as: #67909.
|
This PR is ready. I ran the benchmark numbers for the EnumToString benchmark and the numbers are back to those of segments with this change:
In comparison to regions without the fix:
As a baseline, the numbers for Segments were:
|
Can you check this PR is not the source of this issue? #73254 |
Improvements on |
For WKS, we weren't using the correct
heap_segment_saved_allocated
value as it was overwritten in the plan phase and as a result, we didn't compact causing us to fill up the decommit list and continually callvirtual_commit
andvirtual_decommit
.The fix, specifically for WKS, involves not overwriting the value of
heap_segment_saved_allocated
if it has already been set.This PR is an effort to fix microbenchmarks that regressed after regions were introduced such as: #67909.