Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success test #67418

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Apr 1, 2022

Test if the test passes on CI

@ghost
Copy link

ghost commented Apr 1, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Test if the test passes on CI

Author: rzikm
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP
Copy link
Member

ManickaP commented Apr 1, 2022

Make sure it runs and is not skipped.
Also you can run the test locally in a tight loop to try to get it failed, @wfurt has been doing that a lot to reproduce the failures locally.

@rzikm rzikm force-pushed the 55774-HTTP3-SocketsHttpHandlerTest_Http3_MsQuicClientSettingsReceived_Success-timing-out branch from 2a1ba64 to 990f352 Compare April 6, 2022 12:07
@rzikm rzikm marked this pull request as ready for review April 6, 2022 12:07
@rzikm
Copy link
Member Author

rzikm commented Apr 6, 2022

I have run this test few hundred times in a loop on a VM similar to what is used on the CI and observed no failures of this test.

@rzikm
Copy link
Member Author

rzikm commented Apr 11, 2022

CI Failure is #67712

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes then LGTM, thanks!

@rzikm rzikm merged commit daf25da into dotnet:main Apr 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants