-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LLC cache issue on Apple M1 #64576
Conversation
Unrelated to this PR, when I play with |
cc @dotnet/gc @janvorli |
Btw, here is what |
Thanks @EgorBo for sharing the output of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Addresses the L3 cache issue we've found in #60166 but for macOS-arm64
It seems that since macOS 12.0, Apple added more entries for
sysctl
(see #62832 (comment)). And it turns out the keys we were using report cache size for the "efficiency cores", not the performance ones. As the result,PAL_GetLogicalProcessorCacheSizeFromOS
used to return4mb
instead of expected12mb
.This change shows nice improvements for GC-bound benchmarks and should address #60616 (comment)
Results (Apple M1 mac mini):