-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't run the System.IO.FileSystem.DriveInfo tests in parallel #62134
Conversation
Tagging subscribers to this area: @dotnet/area-system-io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing it.
I wasn't aware that csproj property existed. The only concern I have is if we are making the CI slower now that all test methods from this project will be executed individual instead of parallel. I'd be more inclined on making individual test methods not run in parallel, instead of the whole project. Thoughts?
Same here, I found it by accident when I was refactoring the code for #62132
I was also concerned about the execution time. Before my change it was taking |
Ci failure is known and unrelated (#62028):
|
fixes #62119