Suppress trim warning caused by recent attribute removal changes #62023
Conversation
This fixes a new warning generated by trimming some apps which was introduced in dotnet#54056. The `ComVisibleAttribute` in this case is referenced, but if it's removed it doesn't change functionality in any way.
vitek-karas
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsThis fixes a new warning generated by trimming some apps which was introduced in #54056. This fixes the failure seen in dotnet/sdk#22668 (comment)
|
|
I verified that this fixes the SDK test failure by running the test locally with modified dll from runtime. |
| @@ -69,14 +69,23 @@ internal sealed partial class ReflectTypeDescriptionProvider : TypeDescriptionPr | |||
|
|
|||
| // These are attributes that, when we discover them on interfaces, we do | |||
| // not merge them into the attribute set for a class. | |||
| private static readonly Type[] s_skipInterfaceAttributeList = new Type[] | |||
| private static readonly Type[] s_skipInterfaceAttributeList = InitializeSkipInterfaceAttributeList(); | |||
There was a problem hiding this comment.
Can we add UnconditionalSuppressMessage to this field directly, without adding InitializeSkipInterfaceAttributeList method? It seems to target all applicable constructs.
There was a problem hiding this comment.
Unfortunately that won't work. The warning is coming from a static constructor - which in this case is generated by the compiler. Currently the trimmer has no logic to try to map the warning from a static constructor back to the field (not even sure if it's possible in most cases).
First I simply added an explicit static .cctor, but Roslyn doesn't like it - probably due to beforefieldinit optimization which is really only possible when no explicit .cctor is specified. So the static method is a workaround to that.
There was a problem hiding this comment.
We might want to consider just getting rid of the warning in the trimmer. The warning is a half-hearted attempt to tell the user that the trimmer might have broken their app. It doesn't cover many other cases where stripping the attribute might have broken the app (that cannot be detected because there's no typeof). I believe pretty strongly we need to fix https://github.com/dotnet/linker/issues/2078 and then the warning is unnecessary.
ghost
locked as resolved and limited conversation to collaborators
This fixes a new warning generated by trimming some apps which was introduced in #54056.
The
ComVisibleAttributein this case is referenced, but if it's removed it doesn't change functionality in any way.This fixes the failure seen in dotnet/sdk#22668 (comment)