From 631338df6e8f4ade4df36f910a211200755f98f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Fi=C5=A1era?= Date: Wed, 24 Nov 2021 14:14:28 +0100 Subject: [PATCH 1/2] Remove active issue. --- .../InteropServices/JavaScript/JavaScriptTests.cs | 1 - .../InteropServices/JavaScript/SharedArrayBufferTests.cs | 1 - .../InteropServices/JavaScript/TypedArrayTests.cs | 9 --------- 3 files changed, 11 deletions(-) diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs index 146575af36838..7158c38899c13 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs @@ -11,7 +11,6 @@ namespace System.Runtime.InteropServices.JavaScript.Tests public static class JavaScriptTests { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] public static void CoreTypes() { var arr = new Uint8ClampedArray(50); diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs index d5b7df4cc34cf..7ca2e660a4e9a 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs @@ -6,7 +6,6 @@ namespace System.Runtime.InteropServices.JavaScript.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] public static class SharedArrayBufferTests { private static Function _objectPrototype; diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs index 0b7075893a40d..896835795f198 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs @@ -108,7 +108,6 @@ public static void Float64ArrayFrom(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint8ClampedArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -118,7 +117,6 @@ public static void Uint8ClampedArrayFromSharedArrayBuffer(Function objectPrototy } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint8ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -128,7 +126,6 @@ public static void Uint8ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint16ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -138,7 +135,6 @@ public static void Uint16ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -148,7 +144,6 @@ public static void Uint32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int8ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -158,7 +153,6 @@ public static void Int8ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int16ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -168,7 +162,6 @@ public static void Int16ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -178,7 +171,6 @@ public static void Int32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Float32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -188,7 +180,6 @@ public static void Float32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Float64ArrayFromSharedArrayBuffer(Function objectPrototype) { From 18963ef23553ea23b338aab6bfe4904754d9dc1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Fi=C5=A1era?= Date: Wed, 24 Nov 2021 15:28:51 +0100 Subject: [PATCH 2/2] Use --web-server-use-cop. --- ...stem.Private.Runtime.InteropServices.JavaScript.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj index fe9348f467832..d7b18fc65e150 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj @@ -3,7 +3,7 @@ true $(NetCoreAppCurrent)-Browser true - $(WasmXHarnessArgs) --engine-arg=--expose-gc + $(WasmXHarnessArgs) --engine-arg=--expose-gc --web-server-use-cop