Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] workaround test results corruption #61841

Merged
merged 9 commits into from
Nov 23, 2021
Merged

[wasm] workaround test results corruption #61841

merged 9 commits into from
Nov 23, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 19, 2021 •
edited
Loading

Fixes #61749

@ghost
Copy link

ghost commented Nov 19, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

In hope that it fixes or surfaces more the issue #61749

Author: pavelsavara
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Nov 19, 2021
@ghost
Copy link

ghost commented Nov 19, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In hope that it fixes or surfaces more the issue #61749

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-Infrastructure-libraries
Milestone: -

maraf
maraf approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@maraf maraf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@pavelsavara pavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 19, 2021
lewing
lewing approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the test changes are reverted

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Nov 19, 2021
Closed
@pavelsavara
Copy link
Member Author

Error while saving testResults.xml System.Xml.XmlException: Data at the root level is invalid. Line 2, position 1.

@pavelsavara
Copy link
Member Author

Work in progress here dotnet/xharness#771

@pavelsavara
Copy link
Member Author

Will need new nuget binaries from dotnet/xharness#771

@pavelsavara
Copy link
Member Author

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 22, 2021
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review November 22, 2021 17:37
@pavelsavara pavelsavara requested a review from premun November 22, 2021 17:37
@pavelsavara pavelsavara removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 22, 2021
@pavelsavara pavelsavara requested review from lewing and maraf November 22, 2021 17:37
@pavelsavara
Copy link
Member Author

@radical @maraf @lewing I think this fixes XML corruption problem for WASM.
There are few failed tests for WASM, but I believe they have other causes, Ankit could you please confirm I got it right ?

@premun I know that you are working on bumping all other dependencies too in #61668 shall we wait for that instead of merging it here ?

@premun
Copy link
Member

premun commented Nov 22, 2021

Please merge it here

@radical
Copy link
Member

radical commented Nov 22, 2021

You can ignore the Wasm/Windows/AOT tests.

radical
radical reviewed Nov 22, 2021
View reviewed changes
src/mono/wasm/test-main.js Outdated Show resolved Hide resolved
@radical
Copy link
Member

radical commented Nov 22, 2021

You can ignore the Wasm/Windows/WBT tests also. I am disabling them in #61937 .

maraf
maraf reviewed Nov 23, 2021
View reviewed changes
src/mono/wasm/test-main.js Outdated Show resolved Hide resolved
@pavelsavara pavelsavara merged commit c03a89f into dotnet:main Nov 23, 2021
@pavelsavara pavelsavara deleted the wasm_test_results_corruption branch November 23, 2021 10:44
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@maraf maraf maraf approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@premun premun Awaiting requested review from premun

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] Malformed testResults.xml causing CI test runs to fail
5 participants
@pavelsavara @premun @radical @lewing @maraf