Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use TargetOS=AnyOS in the build-test-job (Try 2) #61801

Merged
merged 11 commits into from
Nov 22, 2021

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Nov 18, 2021

Match the name that's used in the job title and enable us to use TargetOS to pre-filter OS-specific tests with the new Xunit test wrapper generator.

Also do some significant cleanup in the build scripts now that the tests don't reference System.Private.CoreLib.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkoritzinsky jkoritzinsky marked this pull request as ready for review November 20, 2021 15:50
@jkoritzinsky jkoritzinsky requested a review from trylek November 20, 2021 15:50
@ghost
Copy link

ghost commented Nov 20, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Match the name that's used in the job title and enable us to use TargetOS to pre-filter OS-specific tests with the new Xunit test wrapper generator.

Also do some significant cleanup in the build scripts now that the tests don't reference System.Private.CoreLib.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants