Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CI blocking test #61403

Closed
wants to merge 5 commits into from
Closed

Conversation

agocke
Copy link
Member

@agocke agocke commented Nov 10, 2021

activeissues.targets is meant to only disable CI-blocking tests. This PR also
skips the DictionaryExpansion tests on Mono Android to address #61322

activeissues.targets is meant to only disable CI-blocking tests. This PR also
skips the DictionaryExpansion tests on Mono Android to address dotnet#61322
@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

activeissues.targets is meant to only disable CI-blocking tests. This PR also
skips the DictionaryExpansion tests on Mono Android to address #61322

Author: agocke
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@jkoritzinsky
Copy link
Member

Issues.targets already points to issue links and we’ve used it for ActiveIssue-style disables in the past. Why are we creating a new file today for active issues?

@agocke
Copy link
Member Author

agocke commented Nov 10, 2021

I wanted to have a file that's auditable. issues.targets is used for disabling tests just because features don't work on certain platforms, and it's hundreds of lines long.

What I hope to get from activeissues.targets is a list of blocking-ci-only bugs, which should always be a short list, as those bugs should be resolved, either by the product team fixing the bug, or deleting the test.

@agocke agocke changed the title Add activeissues.targets and disable test Disable CI blocking test Nov 10, 2021
@agocke agocke requested a review from jkoritzinsky November 10, 2021 21:10
@jkoritzinsky
Copy link
Member

Given that we have a fix in flight in #61432, let's hold off on merging this until we think that the fix won't be merged before the next rolling build (I don't want to take the "disable" when the fix is already in flight)

@jkoritzinsky
Copy link
Member

The fix has been merged in, so we should be able to close this.

@agocke agocke closed this Nov 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants