-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional steps in gcc validation leg #61241
Conversation
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
dc53d15
to
d433ce8
Compare
cc @safern, @akoeplinger, @lambdageek, perhaps this hybrid approach is not elegant in terms of code; placing non-coreclr steps in |
@am11 since the compiler support is wired up through the root build script, I’d suggest using the global-build-job template instead and pass in a subset argument for all the native subsets and the property to set the native compiler. That will probably be much easier to maintain over time. |
43355b3
to
83855d6
Compare
c54ebe1
to
22542c5
Compare
I am keeping the step in coreclr script for now as it is a minimal change. We have similar steps in that file.
Probably, but lets do the refactoring in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the global-build-job template as @jkoritzinsky suggested, it will be cleaner and easier to maintain long term.
Before:
After: