-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly mark tests with CLRTestKind=SharedLibrary #61235
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsPreviously the Directory.Build.targets script used to automatically In light of this description we can theoretically remove the Thanks Tomas Contributes to: #54512 /cc @dotnet/runtime-infrastructure
|
ccfc3c6
to
0961d58
Compare
OK, I believe I'm finally out of the woods w.r.t. this change, the formatting failure on Windows x64 seems infrastructural and the GC hole in test45929 is known, I sent out a PR yesterday to temporarily block the test out in issues.targets to stop it from plaguing our outerloop runs; I'm retrying both legs now, please review when you have a chance. Thanks Tomas |
Sounds good to me @trylek, I haven't looked at that test yet |
Previously the Directory.Build.targets script used to automatically infer that OutputType=Library without a CLRTestKind implies SharedLibrary. This is however hard to consolidate with the planned test merging - as the SDK script set OutputType=Library by default, we need the combination Library+(implicit)BuildAndRun to indicate the "new-style" [Fact]-based tests. For this reason I propose to remove this automatic inference and manually fix the handful of tests that are missing an explicit CLRTestKind=SharedLibrary property. In light of this description we can theoretically remove the OutputType=Library specification from all test projects but even if we decide to do that, I believe it will be easier to do that as a separate mechanical change, not as part of this relatively small change that has a different purpose. Additionally in the one case of the GitHub_22583 regression test, I removed the explicit setting of GenerateRunScript=false because that's the default. Thanks Tomas
…Library' output type
I believe this was a pre-existing bug - previously, with the special clause regarding SharedLibrary, the test just got silently skipped because it was considered to be a shared library. Thanks Tomas
0961d58
to
aac6425
Compare
The outerloop and PR run have passed, I don't see how library test runs could be affected by my change only targeting CoreCLR tests and I believe the one Mono failure to be unrelated to my change, merging in. |
Previously the Directory.Build.targets script used to automatically
infer that OutputType=Library without a CLRTestKind implies
SharedLibrary. This is however hard to consolidate with the planned
test merging - as the SDK scripts set OutputType=Library by default,
we need the combination Library+(implicit)BuildAndRun to indicate
the "new-style" [Fact]-based tests. For this reason I propose to
remove this automatic inference and manually fix the handful of tests
that are missing an explicit CLRTestKind=SharedLibrary property.
In light of this description we can theoretically remove the
OutputType=Library specification from all test projects but even if
we decide to do that, I believe it will be easier to do it as a
separate mechanical change, not as part of this relatively small
change that has a different purpose. Additionally in the one case
of the GitHub_22583 regression test, I removed the explicit setting
of GenerateRunScript=false because that's the default.
Thanks
Tomas
Contributes to: #54512
/cc @dotnet/runtime-infrastructure