Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sourcelink in source-build to produce .version file in shared fx #60944

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 27, 2021

In 6.0.100, the source-build team noticed the .version file in the source-built shared framework was missing. The file should contain the commit hash and version number. Enabling sourcelink is the clear way to get that infrastructure back online.


Enabling sourcelink regresses a dev scenario for Arcade-powered source-build local builds: due to a sourcelink bug, you must use origin as a remote name:

This probably doesn't affect many people and it's not impossible to adapt to it, so it seems worth going ahead with it anyway.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants