Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sorting requirement for interface lists #60541

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Remove sorting requirement for interface lists #60541

merged 2 commits into from
Nov 8, 2021

Conversation

MichalStrehovsky
Copy link
Member

Fixes #60454.

@ghost
Copy link

ghost commented Oct 18, 2021

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60454.

Author: MichalStrehovsky
Assignees: -
Labels:

area-System.Reflection.Metadata
Milestone: -

@MichalStrehovsky
Copy link
Member Author

@davidwrighton could you have a look at the ECMA spec change proposal?

@runfoapp runfoapp bot mentioned this pull request Oct 19, 2021
Closed
davidwrighton
davidwrighton approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked a bunch of sources to try and find the rationale for this rule, and have come up empty. I think we're good to just change the spec.

@MichalStrehovsky MichalStrehovsky requested a review from tmat November 8, 2021 21:31
@jkotas jkotas merged commit b665721 into dotnet:main Nov 8, 2021
@MichalStrehovsky MichalStrehovsky deleted the fix60454 branch November 8, 2021 21:59
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidwrighton davidwrighton davidwrighton approved these changes

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Metadata
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidateInterfaceImplTable enforces bogus ordering rules
4 participants
@MichalStrehovsky @tmat @davidwrighton @jkotas