-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: don't allow negative edge weights #56651
Conversation
Due to rounding errors or inconsistencies we may end up with unexpected ratios of profile counts. Fix one place where that was leading to a negative edge weight. Fixes dotnet#56647.
Affected test (leakwheel) was asserting about 25% of the time without this fix; ran several hundred times with the fix w/o asserting. Will run the PGO CI pipelines on this one too, as the new asserts may fire for other problematic computations. cc @dotnet/jit-contrib |
/azp run runtime-coreclr pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr libraries-pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
Note the pgo pipelines will probably hit other errors; so I'm mainly checking to see that the new asserts don't fire. |
One leg of the runtime tests has hit this recurring xunit failure (#11063):
|
PGO failures are all "known issues..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
@briansull can you approve? |
Due to rounding errors or inconsistencies we may end up with unexpected
ratios of profile counts. Fix one place where that was leading to a negative
edge weight.
Fixes #56647.