Fix tizen arm32 issue. #55987
Merged
Fix tizen arm32 issue. #55987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
arch-arm32
area-CodeGen-coreclr
|
I checked it works well on Tizen-armel. Thank you! |
clamp03
approved these changes
Jul 20, 2021
|
PTAL @dotnet/jit-contrib |
BruceForstall
approved these changes
Jul 20, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55794, introduced by #55558.
I have decided to go with this fix (see discussion in #55794 (comment)) for now because:
and it causes the argument to be read from memory when before it could stay in float registers.
3. it is dangerous to do morph arg changes when we don't have actual armel testing.