Fix OfficialBuildId property passing down to scripts #52927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed with 4267d56
akoeplinger
approved these changes
May 18, 2021
|
Thanks for checking it. Is it possible to trigger official legs (modulo the actual publishing part)? |
Yes but in this case I would prefer to merge the change in fast to unblock CI and then react to potential official build issues. I will monitor the official builds that will contain the fix to see if something else needs to be done. |
|
The wasm leg passed the check, hence quick merging to unblock broken CI. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed with 4267d56
Validated the fix in #52897
cc @am11