Fix FlushAsyncInternal when emitting BOM #52812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @carlossanlop |
Update StreamWriter.WriteTests.cs Update StreamWriter.WriteTests.cs
|
The CI failed, but it doesn't seem to be related to my changes |
stephentoub
reviewed
May 24, 2021
Comment on lines
944
to
945
| Task flushTask = Core(flushStream, flushEncoder, cancellationToken); | ||
|
|
||
| _charPos = 0; | ||
| return flushTask; |
There was a problem hiding this comment.
This can now be:
return Core(flushStream, flushEncoder, cancellationToken);The separation was just to be able to have the charPos = 0 in the middle, but that's now gone.
There was a problem hiding this comment.
Indeed, should be ok now
stephentoub
approved these changes
May 24, 2021
|
Nice find! |
GrabYourPitchforks
approved these changes
May 24, 2021
stephentoub
approved these changes
May 26, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52811