Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug.Assert on invalid EventSource parameters #52792

Closed

Conversation

MihaZupan
Copy link
Member

Inspired by #52710 and #52025

For tests running against a debug CoreLib build, flag invalid parameters (number, types & null in case of strings).

Debug.Fail on any ReportOutOfBandMessage.

@MihaZupan MihaZupan added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-System.Diagnostics.Tracing labels May 14, 2021
@MihaZupan MihaZupan added this to the 6.0.0 milestone May 14, 2021
@MihaZupan MihaZupan requested review from josalem and sywhang May 14, 2021 21:35
@ghost
Copy link

ghost commented May 14, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Inspired by #52710 and #52025

For tests running against a debug CoreLib build, flag invalid parameters (number, types & null in case of strings).

Debug.Fail on any ReportOutOfBandMessage.

Author: MihaZupan
Assignees: -
Labels:

* NO MERGE *, area-System.Diagnostics.Tracing

Milestone: 6.0.0

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MihaZupan
Copy link
Member Author

Closing until until I have some time to look at the asserts this hit

@MihaZupan MihaZupan closed this Jun 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Tracing NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant