Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsupported browser warnings #43363

Merged
31 commits merged into from
Nov 25, 2020
Merged

Handle unsupported browser warnings #43363

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4d13214
Handle browser warnings
buyaa-n Oct 13, 2020
c94abbf
Merge branch 'master' of https://github.com/dotnet/runtime into add_b…
buyaa-n Oct 16, 2020
148bd59
Apply feedback, revert updates handled with different PRs
buyaa-n Oct 16, 2020
36984e3
Merge branch 'master' of https://github.com/dotnet/runtime into add_b…
buyaa-n Oct 16, 2020
256f290
Add misssing diagnotic id
buyaa-n Oct 20, 2020
99fb042
Merge branch 'master' of https://github.com/dotnet/runtime into add_b…
buyaa-n Oct 20, 2020
351e839
Merge branch 'master' of https://github.com/dotnet/runtime into add_b…
buyaa-n Oct 21, 2020
6267bec
Address multitargeted warnings
buyaa-n Oct 21, 2020
422be5b
Apply feedback
buyaa-n Oct 23, 2020
a523788
Small type/comment updates
buyaa-n Oct 23, 2020
3892c1c
Apply more feedback
buyaa-n Oct 23, 2020
ca6e0fa
Use project settings instead adding Directory.Build.props
buyaa-n Oct 24, 2020
8007c09
Annotate APIs injecting unsupported type through DI
buyaa-n Oct 29, 2020
443aa1f
Fix window support related warnings found with generic type parameter
buyaa-n Nov 2, 2020
f86de1f
Fix another browser warning found with generic type parameter bug fix
buyaa-n Nov 2, 2020
cb052c3
All public APIs of ConsoleLoggerExtensions are unsupported, so markin…
buyaa-n Nov 9, 2020
c70674c
Try handle mono warnings
buyaa-n Nov 10, 2020
2c25aaa
Merge conflicts
buyaa-n Nov 10, 2020
38320a5
Revert mono related changes, it was mistake
buyaa-n Nov 11, 2020
636e5d9
Try handle browser warninga in mono
buyaa-n Nov 11, 2020
7fef65c
Apply feedback and fix new warnings caused from corelib changes
buyaa-n Nov 12, 2020
e5c1673
Review update
buyaa-n Nov 12, 2020
5c9254a
Apply feedback
buyaa-n Nov 12, 2020
f74e50f
Move platform specific section from HttpTelemetry
buyaa-n Nov 13, 2020
ed2b844
Revering unwanted changes
buyaa-n Nov 13, 2020
8d7d39d
Remove redundant attributes
buyaa-n Nov 13, 2020
9a043fe
Exclude cross platform build with browser target
buyaa-n Nov 17, 2020
f6d9618
small updates
buyaa-n Nov 17, 2020
3ba103c
Annotate entire type DiagnosticCounter unsupported
buyaa-n Nov 18, 2020
a804980
Apply feedback, improve suppression comments
buyaa-n Nov 20, 2020
22bb8a2
Remove Unsupported browser from TypeDescriptor.CreateInstance, TypeDe…
buyaa-n Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/versioning.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
</AssemblyAttribute>
</ItemGroup>

<ItemGroup Condition="'$(TargetsBrowser)' == 'true' and '$(IsTestProject)' != 'true'">
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
<SupportedPlatform Include="browser"/>
</ItemGroup>

<ItemGroup>
<_unsupportedOSPlatforms Include="$(UnsupportedOSPlatforms)" />
</ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Net.Http/src/System.Net.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<WindowsRID>win</WindowsRID>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down Expand Up @@ -108,8 +108,6 @@
<Compile Include="System\Net\Http\Headers\WarningHeaderValue.cs" />
<Compile Include="$(CommonPath)System\IO\StreamHelpers.CopyValidation.cs"
Link="Common\System\IO\StreamHelpers.CopyValidation.cs" />
<Compile Include="$(CommonPath)System\Net\Security\SslClientAuthenticationOptionsExtensions.cs"
Link="Common\System\Net\Security\SslClientAuthenticationOptionsExtensions.cs" />
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
<Compile Include="$(CommonPath)System\IO\DelegatingStream.cs"
Link="Common\System\IO\DelegatingStream.cs" />
<Compile Include="$(CommonPath)System\IO\ReadOnlyMemoryStream.cs"
Expand Down Expand Up @@ -185,6 +183,8 @@
Link="Common\System\Net\SecurityStatusPal.cs" />
<Compile Include="$(CommonPath)System\Net\Security\SSPIHandleCache.cs"
Link="Common\System\Net\Security\SSPIHandleCache.cs" />
<Compile Include="$(CommonPath)System\Net\Security\SslClientAuthenticationOptionsExtensions.cs"
Link="Common\System\Net\Security\SslClientAuthenticationOptionsExtensions.cs" />
<Compile Include="$(CommonPath)System\Net\Security\NetEventSource.Security.cs"
Link="Common\System\Net\Security\NetEventSource.Security.cs" />
<Compile Include="$(CommonPath)System\Net\ExceptionCheck.cs"
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,9 @@ private async ValueTask<HttpResponseMessage> SendAsyncCore(
// Wait for the send request to complete, getting back the response.
response = async ?
await base.SendAsync(request, cts.Token).ConfigureAwait(false) :
#pragma warning disable CA1416 // Validate platform compatibility
base.Send(request, cts.Token);
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
#pragma warning restore CA1416
ThrowForNullResponse(response);

// Buffer the response content if we've been asked to.
Expand Down