-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][http] Set HttpResponseMessage.RequestMessage #42822
Conversation
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Are we running our HTTP tests in wasm? I'm wondering if we have a test hole here, or if we do in fact have a test that would catch this but it didn't because we're not running them. |
wasm Http tests in CI are waiting on #40786 but we've done recent manual runs that did not catch this so I suspect a test hole. |
Hmm. I just searched the tests. It's true that there aren't any dedicated to this, and I can fix that. But there are a bunch of tests that just assume this is non-null and would null ref if it was, so something about those manual runs must have skipped all those tests. |
Agreed, we're standing up the tests as quickly as possible. @kjpou1 please look into why the tests aren't catching this. |
/backport release/5.0 |
The issue with the testing here is that browser can't support the loopback server because we don't have sockets and can't listen for requests so all the test that require the loopback server will throw PNSE and have to be skipped. |
Oookeeyyy... that's the vast majority of the functional tests ;-) |
Yeah... I think we're the first platform to hit this but I don't think we will be the last. |
Opened #42852 for discussion |
Lane failure looks like jaredpar/runfo#47 and this change is browser specific |
Fixes #42691