-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crossgen method bodies having ARM64 intrinsic #38060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalspathak
changed the title
Arm64 crossgen
Crossgen method bodies having ARM64 intrinsic
Jun 18, 2020
davidwrighton
requested changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix my comment about wrapping the usage of the InstructionSet flags inside of a TARGET_ARM64 block.
davidwrighton
approved these changes
Jun 19, 2020
This was referenced Jul 21, 2020
Closed
ghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, method bodies containing ARM64 intrinsics are not crossgened. Currently there are not many methods that uses ARM64 intrinsics, but gradually once all the APIs #33308 are intrinsified , it will impact startup time of those methods because they would get JITted first before executing. This PR makes such methods bodies to get crossgened for faster startup time. Additionally, methods of
Vector64
andVector128
were being treated as method calls but since they are intrinsified already (again as part of #33308), it is safe to just crossgen their method bodies.Below is the code size difference. There seems to be regression of 1% but it will still give us good startup time benefits.