CI pipeline for installer #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Packaging for crossgen2 as a framework dependent application. This requires us to manually emit a runtimeconfig json for now, since the build produces a self-contained version of crossgen2. Also includes some minor cleanups to the way we build crossgen2: - Removed from build.proj since we explicitly build it as a self-contained application from build.cmd/build.sh - Removed the output path property from the csproj files. We use an explicit -o argument when publishing to specify the output folder
…025.3 (#8671) - System.Windows.Extensions - 5.0.0-alpha.1.19525.3 - System.CodeDom - 5.0.0-alpha.1.19525.3 - System.Configuration.ConfigurationManager - 5.0.0-alpha.1.19525.3 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.3 - Microsoft.NETCore.Targets - 5.0.0-alpha.1.19525.3 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.3 - Microsoft.Win32.Registry - 5.0.0-alpha.1.19525.3 - Microsoft.Win32.SystemEvents - 5.0.0-alpha.1.19525.3 - Microsoft.Windows.Compatibility - 5.0.0-alpha.1.19525.3 - System.Diagnostics.EventLog - 5.0.0-alpha.1.19525.3 - System.Security.AccessControl - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Cng - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Pkcs - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.ProtectedData - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Xml - 5.0.0-alpha.1.19525.3 - System.Security.Permissions - 5.0.0-alpha.1.19525.3 - System.Security.Principal.Windows - 5.0.0-alpha.1.19525.3 - System.Text.Encodings.Web - 5.0.0-alpha.1.19525.3 - System.Text.Json - 5.0.0-alpha.1.19525.3 - System.Threading.AccessControl - 5.0.0-alpha.1.19525.3 - System.Resources.Extensions - 5.0.0-alpha.1.19525.3 - System.DirectoryServices - 5.0.0-alpha.1.19525.3 - System.Drawing.Common - 5.0.0-alpha.1.19525.3 - System.IO.FileSystem.AccessControl - 5.0.0-alpha.1.19525.3 - System.IO.Packaging - 5.0.0-alpha.1.19525.3
This change modifies R2RDump to use the new System.CommandLine.Experimental module instead of the obsoleted System.CommandLine parser we were using before. Apart from general hygiene w.r.t. using up-to-date components one practical reason for this switch-over is that the old parser is only available on the unreliable myget.org nuget feed we plan to drop as part of our planned repo consolidation. During debugging of the change I noticed a bug in the implementation of the "--verbose" option - it shouldn't be setting EntryPoints, otherwise we actually end up with a super-terse output including just the entry points. I have anecdotally verified that, after fixing this in both the "new" and "old" R2RDump both produce identical output. Thanks Tomas
Signed-off-by: dotnet-bot <[email protected]>
Improved performance of complex casts by caching results of cast analysis. * Easy out for same types. * Introduce cast cache * Use managed heap for the cache * Fixes. Get rid of a fake array typedesc. * TypeDesc conversions caching * Removed NoGC helpers * Cache typedesc conversions * Renamed remaining trivial NoGC casting helpers * Some cleanups. Comments, redundant code. * PR feedback.
* Update dependencies from https://github.com/dotnet/coreclr build 20191025.1 - Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19525.1 - Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19525.1 - Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19525.1 * remove Stopwatch.*.cs from System.Runtime.Extensions build * Disable tests against CoreCLR bug
…aces Signed-off-by: dotnet-bot <[email protected]>
Signed-off-by: dotnet-bot <[email protected]>
…025.2 (#8673) - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.19525.2
…025.2 (#42137) - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19525.2 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.19525.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19525.2 - Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19525.2 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19525.2 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19525.2 - Microsoft.DotNet.GenFacades - 5.0.0-beta.19525.2
…91026.1 (#8674) - NETStandard.Library - 2.2.0-prerelease.19526.1
* Enable building with clang 9 Update the docker images that we use for building. * Add missing clang9 option to build.sh / build-test.sh * Fix clang version matching and MUSL build * Prevent Clang 9 from optimizing out s_gsCookie write
* Can't declare variable and also have extern c * Remove extern c from variable declartion
) Signed-off-by: dotnet-bot <[email protected]>
The file was there to keep anonymous types used by DiagnosticsHandler from having their getters removed. But a) it was relying on the implementation detail name generated by Roslyn, and b) it was keeping alive other state from other anonymous types in the assembly. I changed it to use concrete types instead. This also happens to result in less code, because we don't need the generated Equals/GetHashCode methods generated for anonymous types.
It's not necessary to specify the assembly name when the consumer is in the same assembly.
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13 * Update dependencies from https://github.com/dotnet/corefx build 20191024.14 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14 * Update dependencies from https://github.com/dotnet/corefx build 20191025.6 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6 * Workaround https://github.com/dotnet/coreclr/issues/27465
- Use PreserveDependencyAttribute for ctors used via reflection by FetcherForProperty - Remove reflection use entirely when looking up Activity events
… changes to coreclr/libraries-specific pipelines.
ViktorHofer
reviewed
Nov 5, 2019
ViktorHofer
reviewed
Nov 5, 2019
ViktorHofer
reviewed
Nov 5, 2019
ViktorHofer
reviewed
Nov 5, 2019
tools-local/Directory.Build.props
Outdated
| <!-- TODO: (Consolidation) Remove when consolidated. --> | ||
| <PropertyGroup> | ||
| <IsRuntimeRepository Condition="Exists('..\..\..\.dotnet-runtime-placeholder')">true</IsRuntimeRepository> | ||
| <IsRuntimeRepository Condition="Exists('$(MSBuildThisFileDirectory)..\.dotnet-runtime-placeholder')">true</IsRuntimeRepository> |
There was a problem hiding this comment.
this is already fixed in upstream :)
ViktorHofer
reviewed
Nov 5, 2019
| @@ -118,8 +118,8 @@ jobs: | |||
| - script: | | |||
| set -x | |||
| df -h | |||
| $(RunArguments) $(BuildScript) $(BuildArguments) | |||
| displayName: Build | |||
| $(RunArguments) $(BuildScript) --restore --build --test $(BuildArguments) | |||
There was a problem hiding this comment.
please revert these changes, I submitted the correct fix in the consolidation repo: https://github.com/dotnet/consolidation/pull/16.
There was a problem hiding this comment.
I'll make sure not to backport these specific changes when backporting to core-setup.
|
Thanks @jkoritzinsky! What's your strategy for backporting the changes to upstream? @safern is currently doing the same for corefx so you might want to sync-up with him. |
dagood
reviewed
Nov 5, 2019
| @@ -32,7 +32,7 @@ | |||
| <DebPackageVersion>$(HostPackageVersion)</DebPackageVersion> | |||
| <InputRoot>$(SharedHostPublishRoot)</InputRoot> | |||
| <DebFile>$(SharedHostInstallerFile)</DebFile> | |||
| <ManPagesDir>$(RepoRoot)Documentation/manpages</ManPagesDir> | |||
| <ManPagesDir>$(RepoRoot)docs/installer/manpages</ManPagesDir> | |||
There was a problem hiding this comment.
Also fixed in upstream with dotnet/core-setup#8767 and https://github.com/dotnet/consolidation/pull/17, to point it out. This change is good to get builds going though.
|
/azp run runtime-installer |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
monojenkins
pushed a commit
to monojenkins/runtime
that referenced
this pull request
Jan 23, 2020
`jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread dotnet#1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame dotnet#1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame dotnet#2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame dotnet#3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame dotnet#4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame dotnet#5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame dotnet#6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame dotnet#7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame dotnet#8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame dotnet#9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame dotnet#10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame dotnet#11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame dotnet#12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame dotnet#13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame dotnet#14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame dotnet#15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame dotnet#16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame dotnet#17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame dotnet#18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame dotnet#19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame dotnet#20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame dotnet#21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame dotnet#22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread dotnet#5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame dotnet#1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame dotnet#2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame dotnet#3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame dotnet#4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame dotnet#5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame dotnet#6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame dotnet#7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame dotnet#8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame dotnet#9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame dotnet#10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame dotnet#11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame dotnet#12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame dotnet#13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame dotnet#14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame dotnet#15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number -->
lewurm
added a commit
that referenced
this pull request
Jan 23, 2020
…2073) `jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread #1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame #1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame #2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame #3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame #4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame #5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame #6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame #7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame #8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame #9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame #10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame #11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame #12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame #13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame #14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame #15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame #16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame #17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame #18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame #19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame #20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame #21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame #22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread #5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame #2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame #3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame #4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame #5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame #6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame #7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame #8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame #9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame #10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame #11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame #12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame #13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame #14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame #15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number --> Co-authored-by: Bernhard Urban-Forster <[email protected]>
layomia
pushed a commit
to layomia/dotnet_runtime
that referenced
this pull request
Nov 10, 2020
Sync JsonCodeGen experiment with latest dotnet/runtime master
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the changes I needed to get the CI pipeline building for the installer partition of the repository.
install-nuget-credprovider-then-build.shto understand subsets (not strictly necessary, but it made things a bit cleaner in the initial prototyping day).root/runtimeinstead ofroot/coresetup.installer.cmdandinstaller.shto correctly pass--buildand--restoreon all platforms to restore the tools needed.