Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc enter/leave/poll without HELPER_METHOD_FRAME #109378

Merged
merged 39 commits into from
Jan 16, 2025
Merged

Gc enter/leave/poll without HELPER_METHOD_FRAME #109378

merged 39 commits into from
Jan 16, 2025

Conversation

davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Oct 30, 2024 •
edited
Loading

Rewrite gc polling logic as a managed helper and remove the stress helper. Also move the pinvoke suspension and rare disable paths to take advantage of the QCall infrastructure.

@davidwrighton
Part1 Of implement InitClass helpers
0fbff89
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into initclass_managed
7d6a205
@davidwrighton
It builds and works
51c69d5
@davidwrighton
Revert unnecessary changes
d1fccda
@davidwrighton
Ooops we did need to keep the refactoring that put the debug only Met…
08fe963 
…hodDesc fields after the normal fields.
@davidwrighton
Merge branch 'initclass_managed' into thread_static_helpers
12c9de2
@davidwrighton
Initial work which does static helpers
2c0cb78
@davidwrighton
Fix build break
0fb7f4a
@davidwrighton
Thread statics basically implemented...
0cb8f78
@davidwrighton
Merge branch 'main' of https://github.com/dotnet/runtime into thread_…
aacdb2a 
…static_helpers
@davidwrighton
Finish merging in changes from main, and fix up some oopses... and it…
00b6df4 
… works!
@davidwrighton
Restructure static access so that we don't need a helper call to acce…
34ebcaf 
…ss static data. Should result in very similar to native codegen patterns
@davidwrighton
Tweaks for failures noted in PR testing
f740618
@davidwrighton
Fix comments on Unix builds for Arm64 and RISCV
e2498bb
@davidwrighton
Tail call the right helper
0d03a51
@davidwrighton
Force volatile loads for the statics ref, to fix the arm64 statics ra…
367e95b 
…ce condition
@davidwrighton
Get rid of extra null check
ccfafe1
@davidwrighton
Fix error around fcall class ordering
5ff66b4
@davidwrighton
Attempt to fix Unix assembly code, and fix fcall registration
0586455
@davidwrighton
Properly thread through using the "optimized" helper 2 for thread sta…
0f6290a 
…tics even when tls jit optimizations are disabled
@davidwrighton
Remove unnecessary changes from the PR
8f5448f
@davidwrighton
Merge branch 'main' of https://github.com/dotnet/runtime into thread_…
2152544 
…static_helpers
@davidwrighton
Rewrite gc polling as a managed helper and remove the stress helper
2c9bc7d
@davidwrighton
Remove polling logic
1d4b19a
@davidwrighton
Merge branch 'main' of https://github.com/dotnet/runtime into gc_poll…
82fcb9f 
…_without_hmf
@davidwrighton
More merging of the statics change
2f7c7aa
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Oct 30, 2024
Open
3 tasks
This was referenced Dec 7, 2024
Open
Closed
Open
This was referenced Dec 10, 2024
Open
Closed
@davidwrighton davidwrighton changed the title Gc poll without HELPER_METHOD_FRAME Gc enter/leave/poll without HELPER_METHOD_FRAME Jan 8, 2025
@davidwrighton davidwrighton mentioned this pull request Jan 8, 2025
Open
25 tasks
am11
am11 reviewed Jan 8, 2025
View reviewed changes
src/coreclr/vm/jithelpers.cpp Outdated Show resolved Hide resolved
am11
am11 reviewed Jan 9, 2025
View reviewed changes
src/coreclr/vm/i386/jithelp.S Outdated Show resolved Hide resolved
am11
am11 reviewed Jan 9, 2025
View reviewed changes
src/coreclr/vm/i386/jithelp.S Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Jan 9, 2025
Open
3 tasks
@davidwrighton davidwrighton marked this pull request as ready for review January 9, 2025 23:08
@davidwrighton @am11
Apply suggestions from code review
6c92aad 
Fixes for the X86 Unix assembly paths

Co-authored-by: Adeel Mujahid <[email protected]>
@davidwrighton
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Jan 15, 2025
@davidwrighton davidwrighton merged commit be318b1 into dotnet:main Jan 16, 2025
105 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am11 am11 am11 left review comments

@AustinWise AustinWise AustinWise left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@davidwrighton davidwrighton

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwrighton @AustinWise @am11 @AaronRobinsonMSFT