JIT: Propagate LCL_ADDRs into natural loops #109190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can allow keeping assertions around for natural loop headers provided that we precompute the set of locals whose assertions may be killed inside the loop.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @AndyAyersMS |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Only do the IR walk when we have assertions going into a loop.
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Oct 25, 2024
|
Windows x64 Improvements: dotnet/perf-autofiling-issues#43918 |
This was referenced Oct 29, 2024
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can allow keeping assertions around for natural loop headers provided that we precompute the set of locals whose assertions may be killed inside the loop.
Reusing
LoopLocalOccurrencesdid not turn out to be simple because of differences in walking IR and also because this runs at a time where the IR is in an odd state due to halfway morphed promoted implicit byref locals.New version of #102965