Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update debugging-runtime.md #106518

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Update debugging-runtime.md #106518

merged 5 commits into from
Aug 16, 2024

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Aug 16, 2024 •
edited
Loading

  • MSFT style guide, e.g. avoid future tense.
  • Less is more
  • Recommended approach first.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@Rick-Anderson
Copy link
Contributor Author

@gregg-miskelly @steveharter can you recommend an approved reviewer?

@gregg-miskelly
Copy link
Contributor

@tommcdon Can you review this documentation change for @Rick-Anderson?

tommcdon
tommcdon approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tommcdon tommcdon merged commit 78def3e into main Aug 16, 2024
4 checks passed
@jkotas jkotas deleted the Rick-Anderson-patch-1 branch August 18, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommcdon tommcdon tommcdon approved these changes

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Assignees

@Rick-Anderson Rick-Anderson

Labels
area-Infrastructure-coreclr
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rick-Anderson @gregg-miskelly @tommcdon