-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for open generic types in attributes #103213
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Jun 9, 2024
This is a partial prototype for a runtime support of a proposed C# language feature. There is not much to review. We should agree first that this is a C# language feature that we want to build. |
jkotas
added
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Jun 12, 2024
Per @jkotas comment, closing this PR as it's not ready for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Reflection
community-contribution
Indicates that the PR has been added by a community member
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable open generic types in attributes.
Passing generic context in S.P.CoreLib so that open generic types can be resolved.
Skip instantiating generic attribute type if any type parameter is not provided.
Language proposal: dotnet/csharplang#8198
Pseudo C# code:
IL for testing: il.txt
Output:
Tests will be added later.