Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/x64: 1 Regressions on 2/14/2024 8:50:48 AM #98706

Closed
performanceautofiler bot opened this issue Feb 20, 2024 · 4 comments
Closed

[Perf] Windows/x64: 1 Regressions on 2/14/2024 8:50:48 AM #98706

performanceautofiler bot opened this issue Feb 20, 2024 · 4 comments
Assignees
@jakobbotsch
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime
Milestone
9.0.0

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Feb 20, 2024 •
edited by DrewScoggins
Loading

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline fae6720d5717297446b5f01a605260845420e622
Compare 9aaac42bcdfb36225d9d6eb8c45e15bbbf816d11
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Linq.Tests.Perf_Enumerable

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
217.01 ns 238.93 ns 1.10 0.01 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Linq.Tests.Perf_Enumerable*'

Payloads

Baseline
Compare

System.Linq.Tests.Perf_Enumerable.AnyWithPredicate_LastElementMatches(input: Array)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Feb 20, 2024
@performanceautofiler performanceautofiler bot mentioned this issue Feb 20, 2024
Closed
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Feb 20, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 20, 2024
@DrewScoggins
Copy link
Member

Looks related to #98096

@DrewScoggins DrewScoggins changed the title [Perf] Windows/x64: 7 Regressions on 2/14/2024 8:50:48 AM [Perf] Windows/x64: 1 Regressions on 2/14/2024 8:50:48 AM Feb 20, 2024
@DrewScoggins
Copy link
Member

DrewScoggins commented Feb 20, 2024 •
edited
Loading

Windows Amd64: dotnet/perf-autofiling-issues#29542
Linux x64: dotnet/perf-autofiling-issues#29446, dotnet/perf-autofiling-issues#29449

@danmoseley danmoseley added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 20, 2024
@ghost
Copy link

ghost commented Feb 20, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline fae6720d5717297446b5f01a605260845420e622
Compare 9aaac42bcdfb36225d9d6eb8c45e15bbbf816d11
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Linq.Tests.Perf_Enumerable

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
217.01 ns 238.93 ns 1.10 0.01 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Linq.Tests.Perf_Enumerable*'

Payloads

Baseline
Compare

System.Linq.Tests.Perf_Enumerable.AnyWithPredicate_LastElementMatches(input: Array)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

os-windows, arch-x64, area-CodeGen-coreclr, untriaged, runtime-coreclr
Milestone: -

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Feb 26, 2024
@BruceForstall BruceForstall added this to the 9.0.0 milestone Feb 26, 2024
@jakobbotsch
Copy link
Member

This has improved since:
image

Most likely from #98324.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
4 participants
@danmoseley @jakobbotsch @DrewScoggins @BruceForstall