Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unix Console.ReadLine by borrowing from PowerShell's ReadLineFromConsole #94860

Closed
tmds opened this issue Nov 16, 2023 · 5 comments
Closed
Assignees
Milestone

Comments

@tmds
Copy link
Member

tmds commented Nov 16, 2023

On Unix, .NET uses its own Console.ReadLine implementation which is very minimalistic.

PowerShell has a more feature rich ReadLine implementation here: https://github.com/PowerShell/PowerShell/blame/5cd04f2377b624dedd17a85ff3f38a0343292477/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs#L1567.
It include things like: arrows keys, home, end, delete, ...

We can borrow some things from that to improve the UX of Console.ReadLine on Unix.

cc @dotnet/area-system-console @adamsitnik @stephentoub

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 16, 2023
@ghost
Copy link

ghost commented Nov 16, 2023

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

On Unix, .NET uses its own Console.ReadLine implementation which is very minimalistic.

PowerShell has a more feature rich ReadLine implementation here: https://github.com/PowerShell/PowerShell/blame/5cd04f2377b624dedd17a85ff3f38a0343292477/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs#L1567.
It include things like: arrows keys, home, end, delete, ...

We can borrow some things from that to improve the UX of Console.ReadLine on Unix.

cc @dotnet/area-system-console @adamsitnik @stephentoub

Author: tmds
Assignees: -
Labels:

area-System.Console

Milestone: -

@gfoidl

This comment was marked as outdated.

@tmds tmds changed the title Improve Unix Console.WriteLine by borrowing from PowerShell's ReadLineFromConsole Improve Unix Console.ReadLine by borrowing from PowerShell's ReadLineFromConsole Nov 17, 2023
@adamsitnik
Copy link
Member

We would get #38051 fixed? That would be great! I am supportive of that idea.

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Nov 17, 2023
@adamsitnik adamsitnik added this to the Future milestone Nov 17, 2023
@adamsitnik adamsitnik added the help wanted [up-for-grabs] Good issue for external contributors label Nov 17, 2023
@tmds
Copy link
Member Author

tmds commented Nov 17, 2023

Yes, arrow keys are part of this.

You can assign this to me.

@adamsitnik adamsitnik removed the help wanted [up-for-grabs] Good issue for external contributors label Nov 17, 2023
@tmds
Copy link
Member Author

tmds commented Nov 29, 2023

Closing in favor of #38051. See comment: #38051 (comment).

@adamsitnik adamsitnik closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants