Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Proposal]: Arm64: FEAT_SVE_SM4 #94426

Open
a74nh opened this issue Nov 6, 2023 · 2 comments
Open

[API Proposal]: Arm64: FEAT_SVE_SM4 #94426

a74nh opened this issue Nov 6, 2023 · 2 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation arch-arm64 area-System.Runtime.Intrinsics
Milestone

Comments

@a74nh
Copy link
Contributor

a74nh commented Nov 6, 2023

namespace System.Runtime.Intrinsics.Arm

/// VectorT Summary
public abstract class SveSm4 : AdvSimd /// Feature: FEAT_SVE_SM4
{

  public static unsafe Vector<uint> Sm4EncryptionAndDecryption(Vector<uint> left, Vector<uint> right); // SM4E

  public static unsafe Vector<uint> Sm4KeyUpdates(Vector<uint> left, Vector<uint> right); // SM4EKEY

  /// total method signatures: 2

}


/// Full API
public abstract class SveSm4 : AdvSimd /// Feature: FEAT_SVE_SM4
{
    /// Sm4EncryptionAndDecryption : SM4 encryption and decryption

    /// svuint32_t svsm4e[_u32](svuint32_t op1, svuint32_t op2) : "SM4E Ztied1.S, Ztied1.S, Zop2.S"
  public static unsafe Vector<uint> Sm4EncryptionAndDecryption(Vector<uint> left, Vector<uint> right);


    /// Sm4KeyUpdates : SM4 key updates

    /// svuint32_t svsm4ekey[_u32](svuint32_t op1, svuint32_t op2) : "SM4EKEY Zresult.S, Zop1.S, Zop2.S"
  public static unsafe Vector<uint> Sm4KeyUpdates(Vector<uint> left, Vector<uint> right);


  /// total method signatures: 2
  /// total method names:      2
}


  /// Total ACLE covered across API:      2
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 6, 2023
@ghost
Copy link

ghost commented Nov 6, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details
namespace System.Runtime.Intrinsics.Arm

/// VectorT Summary
public abstract class SveSm4 : AdvSimd /// Feature: FEAT_SVE_SM4
{

  public static unsafe Vector<uint> Sm4EncryptionAndDecryption(Vector<uint> left, Vector<uint> right); // SM4E

  public static unsafe Vector<uint> Sm4KeyUpdates(Vector<uint> left, Vector<uint> right); // SM4EKEY

  /// total method signatures: 2

}


/// Full API
public abstract class SveSm4 : AdvSimd /// Feature: FEAT_SVE_SM4
{
    /// Sm4EncryptionAndDecryption : SM4 encryption and decryption

    /// svuint32_t svsm4e[_u32](svuint32_t op1, svuint32_t op2) : "SM4E Ztied1.S, Ztied1.S, Zop2.S"
  public static unsafe Vector<uint> Sm4EncryptionAndDecryption(Vector<uint> left, Vector<uint> right);


    /// Sm4KeyUpdates : SM4 key updates

    /// svuint32_t svsm4ekey[_u32](svuint32_t op1, svuint32_t op2) : "SM4EKEY Zresult.S, Zop1.S, Zop2.S"
  public static unsafe Vector<uint> Sm4KeyUpdates(Vector<uint> left, Vector<uint> right);


  /// total method signatures: 2
  /// total method names:      2
}


  /// Total ACLE covered across API:      2
Author: a74nh
Assignees: -
Labels:

area-System.Runtime.Intrinsics

Milestone: -

@a74nh
Copy link
Contributor Author

a74nh commented Nov 6, 2023

This contributes to #93095

It covers all of the instructions in FEAT_SVE_SM4.
This list was auto generated from the C ACLE for SVE, and is in three parts:

The methods list reduced down to Vector versions. All possible varaints of T are given above the method.
The complete list of all methods. The corresponding ACLE methods and SVE instructions are given above the method.
All rejected ACLE methods. These are methods we have agreed that do not need including in C#.
Where possible, existing C# naming conventions have been matched.

Many of the C functions include predicate argument(s), of type svbool_t as the first argument. These are missing from the C# method. It is expected that the Jit will create predicates where required, or combine with uses of conditionalSelect(). For more discussion see #88140 comment.

@kunalspathak kunalspathak added the api-ready-for-review API is ready for review, it is NOT ready for implementation label Feb 7, 2024
@kunalspathak kunalspathak added this to the Future milestone May 1, 2024
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label May 3, 2024
@tannergooding tannergooding added api-suggestion Early API idea and discussion, it is NOT ready for implementation arch-arm64 and removed api-ready-for-review API is ready for review, it is NOT ready for implementation labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation arch-arm64 area-System.Runtime.Intrinsics
Projects
None yet
Development

No branches or pull requests

4 participants