[wasm][debugger] Evaluate methods with short arguments #93057
Labels
arch-wasm
WebAssembly architecture
area-Debugger-mono
enhancement
Product code improvement that does NOT require public API changes/additions
Milestone
We do not have a mechanism of detecting if literal is short, so both options from each case:
are falling into the non-short category in
MonoSdbHelper.WriteNumbers
. The simplest fix for it that comes to my mind is a mechanism ofInvokeMethod
retries every time we detect a numeric literal that is of type int/byte/uint. With multiple parameters that classify for retry, the number of retries grows exponentially which is not the best solution.Uncomment
in
EvaluateMethodWithDefaultParam
test. Current behavior:"No implementation of method 'GetDefaultNegativeShortInt' matching 'test.GetDefaultNegativeShortInt(-123)' found in type DebuggerTests.DefaultParamMethods.TestClass.",
Coreclr behavior for the short int tests scenarios:
![image](https://private-user-images.githubusercontent.com/32700855/272881701-8583d5bc-9437-483f-9fd9-f5fa870e5267.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4MTE5NDQsIm5iZiI6MTczOTgxMTY0NCwicGF0aCI6Ii8zMjcwMDg1NS8yNzI4ODE3MDEtODU4M2Q1YmMtOTQzNy00ODNmLTlmZDktZjVmYTg3MGU1MjY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE3VDE3MDA0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmN2NmOTU5Y2EwMDE3NTc2MGRmOTVjZDUwYjY4MDA4NWUzNDEwNGI5MzBjNGZmMjczZmFiZjE4NDk1ZjVlMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bWHrr1BS_FOE0vneqZ72XAiyqWeRcxhngqlc5sqka9I)
The text was updated successfully, but these errors were encountered: