-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Update tests to be trim-compatible on ios/tvos platforms #91923
Comments
Tagging subscribers to this area: @directhex Issue DetailsBy enabling trimming when building libraries and functional tests for ios/tvos platforms, we would greatly speed up builds on CI, lower the costs and improve user experience. With trimming enabled the configuration is also closer to what an end user experiences when building ios/tvos applications. However, as some tests assume trimming is not enabled (e.g.:
|
@kotlarmilos why did we reopen this issue? |
There are tests disabled against this issue. |
I see thanks, I was confused as the original issue got edited and the description was not, so was wondering what is the current/end state of this. Additionally, some of the disabled tests seem to have separate issues: We should clean this up. |
Yes, there was a regression, and we want to re-enable it. It is a stale PR, but I will try to push it forward. |
By enabling trimming when building libraries and functional tests for ios/tvos platforms, we would greatly speed up builds on CI, lower the costs and improve user experience. With trimming enabled the configuration is also closer to what an end user experiences when building ios/tvos applications.
However, as some tests assume trimming is not enabled (e.g.:
System.Runtime.Tests
test suite has 11 failures onios-arm64
device when trimming is enabled) we should investigate how to root required assemblies/tests to prevent these failures.Related issues:
Disabled tests:
Follow-up tasks:
/azp rerun ios-platforms-no-trimming
The text was updated successfully, but these errors were encountered: