Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Update tests to be trim-compatible on ios/tvos platforms #91923

Open
2 tasks
ivanpovazan opened this issue Sep 12, 2023 · 5 comments · Fixed by #100669 or #104097
Open
2 tasks

[mono] Update tests to be trim-compatible on ios/tvos platforms #91923

ivanpovazan opened this issue Sep 12, 2023 · 5 comments · Fixed by #100669 or #104097
Assignees
Labels
area-Infrastructure-mono disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Sep 12, 2023

By enabling trimming when building libraries and functional tests for ios/tvos platforms, we would greatly speed up builds on CI, lower the costs and improve user experience. With trimming enabled the configuration is also closer to what an end user experiences when building ios/tvos applications.

However, as some tests assume trimming is not enabled (e.g.: System.Runtime.Tests test suite has 11 failures on ios-arm64 device when trimming is enabled) we should investigate how to root required assemblies/tests to prevent these failures.

Related issues:

Disabled tests:

Microsoft.Extensions.Configuration.Binder.Tests.TraceSwitchTest
Microsoft.Extensions.Configuration.Binder.Tests.TestGraphWithUnsupportedMember
System.Reflection.Metadata.Decoding.Tests.SimpleSignatureProviderCoverage
System.Reflection.Tests.GetModuleVersionId_KnownAssembly_ReturnsExpected
System.Runtime.Tests.ShimsHaveOnlyTypeForwards

Follow-up tasks:

  • Rerun the same state with trimming disabled, to discover trim-related issues (/azp rerun ios-platforms-no-trimming
  • Make disabled tests trim-compatible
@ghost
Copy link

ghost commented Sep 12, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

By enabling trimming when building libraries and functional tests for ios/tvos platforms, we would greatly speed up builds on CI, lower the costs and improve user experience. With trimming enabled the configuration is also closer to what an end user experiences when building ios/tvos applications.

However, as some tests assume trimming is not enabled (e.g.: System.Runtime.Tests test suite has 11 failures on ios-arm64 device when trimming is enabled) we should investigate how to root required assemblies/tests to prevent these failures.

Author: ivanpovazan
Assignees: -
Labels:

area-Infrastructure-mono, os-ios

Milestone: 9.0.0

@ivanpovazan ivanpovazan self-assigned this Sep 12, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 26, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 27, 2023
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Mar 11, 2024
@kotlarmilos kotlarmilos changed the title [mono] Investigate enabling trimming when building libraries and functional tests on ios/tvos platforms [mono] Update tests to be trim-compatible on ios/tvos platforms Apr 12, 2024
@kotlarmilos kotlarmilos added disabled-test The test is disabled in source code against the issue and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 12, 2024
@kotlarmilos kotlarmilos reopened this Apr 12, 2024
@ivanpovazan
Copy link
Member Author

@kotlarmilos why did we reopen this issue?

@jkotas
Copy link
Member

jkotas commented Jul 29, 2024

There are tests disabled against this issue.

@ivanpovazan
Copy link
Member Author

ivanpovazan commented Jul 29, 2024

I see thanks, I was confused as the original issue got edited and the description was not, so was wondering what is the current/end state of this. Additionally, some of the disabled tests seem to have separate issues:
e.g.: ShimsHaveOnlyTypeForwards -> #99592

We should clean this up.

@kotlarmilos
Copy link
Member

Yes, there was a regression, and we want to re-enable it. It is a stale PR, but I will try to push it forward.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 2, 2024
@vitek-karas vitek-karas modified the milestones: 9.0.0, 10.0.0 Aug 22, 2024
@kotlarmilos kotlarmilos added tracking This issue is tracking the completion of other related issues. and removed in-pr There is an active PR which will close this issue when it is merged labels Nov 25, 2024
@kotlarmilos kotlarmilos reopened this Nov 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-mono disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS tracking This issue is tracking the completion of other related issues.
Projects
None yet
4 participants