Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libs] Refactor System.Dynamic.Utils.DelegateHelpers to utilize UnsafeAccessorAttribute #90548

Open
ivanpovazan opened this issue Aug 14, 2023 · 2 comments

Comments

@ivanpovazan
Copy link
Member

As discussed in: #90519 both:

should utilize UnsafeAccessorAttribute to simplify the logic of accessing the internal static methods in Delegate and AssemblyBuilder respectfully.

This would additionally remove the need for Internal.Runtime.Augments.DynamicDelegateAugments forwarder and simplify the code in general.

For reference: similar refactoring has been done in: #89706

@ivanpovazan ivanpovazan added this to the 9.0.0 milestone Aug 14, 2023
@ivanpovazan ivanpovazan self-assigned this Aug 14, 2023
@ghost
Copy link

ghost commented Aug 14, 2023

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in: #90519 both:

should utilize UnsafeAccessorAttribute to simplify the logic of accessing the internal static methods in Delegate and AssemblyBuilder respectfully.

This would additionally remove the need for Internal.Runtime.Augments.DynamicDelegateAugments forwarder and simplify the code in general.

For reference: similar refactoring has been done in: #89706

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

area-System.Linq.Expressions

Milestone: 9.0.0

@SamMonoRT
Copy link
Member

cc @fanyang-mono fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants