-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Roslyn interceptors feature in config binder generator #89322
Comments
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue Detailsref: @captainsafia's work on the request delegate source generator - dotnet/aspnetcore#48817. cc @tarekgh @eerhardt @ericstj.
|
Can take this opportunity to fix #86363. |
@tarekgh @ericstj @eiriktsarpalis looks like the interceptors feature requires The Web SDK already sets the feature property when binding & RDG generates are enabled, so the concern is about regular SDK scenarios. |
@layomia does the interceptor feature will be released the same way? I mean users have to opt-in to get it. Or is this temporary for preview and will change when it gets released? |
Yes I believe interceptors will be shipped as a preview feature in GA. cc @captainsafia. |
We can do the same thing as RDG here. Just add us to this condition: We could do the same in our nuget package targets: Might be good to have a safeguard in the generator just in case someone manages to invoke it without setting that property. I suspect RDG needs the same as well (eg Web class library that get's referenced by a normal app or class library). |
ref: @captainsafia's work on the request delegate source generator - dotnet/aspnetcore#48817.
cc @tarekgh @eerhardt @ericstj.
The text was updated successfully, but these errors were encountered: