Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle recursive type graphs in config binding generator #83539

Closed
layomia opened this issue Mar 16, 2023 · 1 comment · Fixed by #83644
Closed

Handle recursive type graphs in config binding generator #83539

layomia opened this issue Mar 16, 2023 · 1 comment · Fixed by #83644
Assignees
@layomia
Labels
area-Extensions-Configuration bug source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Mar 16, 2023

e.g. Handle recursive type graphs e.g. MyClass { List<MyClass> }.
Generator was added in #82179. Relevant logic is in the parser. Fix is to cache a new type spec immediately after encountering the ITypeSymbol, then initializing the new spec in a late-bound manner (e.g. via a method on the spec type).
@layomia layomia added bug area-Extensions-Configuration source-generator Indicates an issue with a source generator feature labels Mar 16, 2023
@layomia layomia added this to the 8.0.0 milestone Mar 16, 2023
@layomia layomia self-assigned this Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

e.g. Handle recursive type graphs e.g. MyClass { List<MyClass> }.
Generator was added in #82179. Relevant logic is in the parser. Fix is to cache a new type spec immediately after encountering the ITypeSymbol, then initializing the new spec in a late-bound manner (e.g. via a method on the spec type).

Author: layomia
Assignees: layomia
Labels:

bug, area-Extensions-Configuration, source-generator
Milestone: 8.0.0

This was referenced Mar 16, 2023
Closed
Merged
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 19, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-Extensions-Configuration bug source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Handle recursive type graphs in config binding generator layomia/dotnet_runtime
1 participant
@layomia