Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 2 Regressions on 11/4/2022 2:24:58 AM #78838

Closed
performanceautofiler bot opened this issue Nov 15, 2022 · 3 comments
Closed

[Perf] Linux/x64: 2 Regressions on 11/4/2022 2:24:58 AM #78838

performanceautofiler bot opened this issue Nov 15, 2022 · 3 comments
Assignees
Labels
arch-x64 os-linux Linux OS (any supported distro) PGO

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 9a138bf5cb4a9055e4e0370a3eb3883514555fcd
Compare d3198e08ed76c1890048c32598275516ac67f519
Diff Diff

Regressions in System.Tests.Perf_Enum

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Parse - Duration of single invocation 3.50 μs 4.04 μs 1.16 0.02 False
Parse - Duration of single invocation 1.75 μs 2.35 μs 1.34 0.01 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Enum*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Tests.Perf_Enum.Parse(text: "Red, Orange, Yellow, Green, Blue")


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 4.042615457957958 > 3.663957797946361.
IsChangePoint: Marked as a change because one of 10/11/2022 6:23:40 AM, 11/2/2022 4:25:40 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -23.533037504777596 (T) = (0 -4110.069504832147) / Math.Sqrt((1260.4177787743124 / (21)) + (14170.454302842225 / (22))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (22) - 2, .025) and -0.17915386011827372 = (3485.609167594033 - 4110.069504832147) / 3485.609167594033 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Tests.Perf_Enum.Parse(text: "Red")

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 2.3472273457168673 > 1.8546446580003118.
IsChangePoint: Marked as a change because one of 10/10/2022 3:36:43 PM, 11/2/2022 4:25:40 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -84.98394278999088 (T) = (0 -2352.9473955210738) / Math.Sqrt((412.63687148997013 / (21)) + (631.3137273182855 / (22))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (22) - 2, .025) and -0.335349254391315 = (1762.0464367530612 - 2352.9473955210738) / 1762.0464367530612 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added PGO refs/heads/main untriaged New issue has not been triaged by the area owner labels Nov 15, 2022
@kotlarmilos
Copy link
Member

Regression in 5d0943f

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 16, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@vargaz
Copy link
Contributor

vargaz commented Nov 29, 2022

Will be fixed by
#78840

@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 os-linux Linux OS (any supported distro) PGO
Projects
None yet
Development

No branches or pull requests

4 participants