Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 2 Regressions on 10/23/2022 8:43:59 AM #78811

Closed
performanceautofiler bot opened this issue Oct 25, 2022 · 4 comments
Closed

[Perf] Linux/x64: 2 Regressions on 10/23/2022 8:43:59 AM #78811

performanceautofiler bot opened this issue Oct 25, 2022 · 4 comments
Assignees
Labels

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline ebf4ea7601f82cdc3f7cb9e7539a84e423d0d23a
Compare 33cb335386d39da8e4e89e75449628be7e3b375a
Diff Diff

Regressions in System.Collections.Tests.Perf_SortedSet

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Min - Duration of single invocation 88.38 ns 93.73 ns 1.06 0.23 False
Max - Duration of single invocation 128.79 ns 145.35 ns 1.13 0.13 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.Tests.Perf_SortedSet*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Collections.Tests.Perf_SortedSet.Min


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 93.72826836778536 > 91.51960243883491.
IsChangePoint: Marked as a change because one of 10/22/2022 11:54:51 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -8.029056995513429 (T) = (0 -98.18944665057033) / Math.Sqrt((10.350952961508359 / (35)) + (8.416189005757431 / (6))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (6) - 2, .025) and -0.11927874123950591 = (87.72564244527139 - 98.18944665057033) / 87.72564244527139 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_SortedSet.Max

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 145.34924607678118 > 136.37800297963952.
IsChangePoint: Marked as a change because one of 10/22/2022 11:54:51 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -11.531651181756974 (T) = (0 -146.16725975874093) / Math.Sqrt((13.78208659750678 / (35)) + (10.432484401430795 / (6))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (6) - 2, .025) and -0.13021097851785113 = (129.32741102057193 - 146.16725975874093) / 129.32741102057193 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added refs/heads/main untriaged New issue has not been triaged by the area owner labels Oct 25, 2022
@kotlarmilos
Copy link
Member

Hey @BrzVlad regression in 72eb39c

I can also take a look

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Oct 26, 2022
@kotlarmilos kotlarmilos self-assigned this Nov 24, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@BrzVlad
Copy link
Member

BrzVlad commented Nov 24, 2022

seems like noise to me

@ghost
Copy link

ghost commented Nov 25, 2022

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline ebf4ea7601f82cdc3f7cb9e7539a84e423d0d23a
Compare 33cb335386d39da8e4e89e75449628be7e3b375a
Diff Diff

Regressions in System.Collections.Tests.Perf_SortedSet

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Min - Duration of single invocation 88.38 ns 93.73 ns 1.06 0.23 False
Max - Duration of single invocation 128.79 ns 145.35 ns 1.13 0.13 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.Tests.Perf_SortedSet*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Collections.Tests.Perf_SortedSet.Min


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 93.72826836778536 > 91.51960243883491.
IsChangePoint: Marked as a change because one of 10/22/2022 11:54:51 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -8.029056995513429 (T) = (0 -98.18944665057033) / Math.Sqrt((10.350952961508359 / (35)) + (8.416189005757431 / (6))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (6) - 2, .025) and -0.11927874123950591 = (87.72564244527139 - 98.18944665057033) / 87.72564244527139 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_SortedSet.Max

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 145.34924607678118 > 136.37800297963952.
IsChangePoint: Marked as a change because one of 10/22/2022 11:54:51 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -11.531651181756974 (T) = (0 -146.16725975874093) / Math.Sqrt((13.78208659750678 / (35)) + (10.432484401430795 / (6))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (6) - 2, .025) and -0.13021097851785113 = (129.32741102057193 - 146.16725975874093) / 129.32741102057193 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: kotlarmilos
Labels:

area-Codegen-Interpreter-mono, refs/heads/main, ubuntu 18.04, Regression, x64

Milestone: -

@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants