-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Linux/x64: 4 Regressions on 9/27/2022 4:04:11 PM #78805
Comments
Run Information
Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Net.Primitives.Tests.IPAddressPerformanceTests*' PayloadsHistogramEdge Detector InfoSystem.Net.Primitives.Tests.IPAddressPerformanceTests.Ctor_Span(address: [16, 32, 48, 64, 80, ...])
Description of detection logic
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
Regressions in PerfLabTests.LowLevelPerf
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'PerfLabTests.LowLevelPerf*' PayloadsHistogramEdge Detector InfoPerfLabTests.LowLevelPerf.NewDelegateClassEmptyInstanceFn
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository |
Looks like regression - @stephentoub could you take a look? |
It's definitely not 31e0bd1, which is changing Enumerable.Min/Max. It's very likely 0075639...1f688ed, which is changing IPAddress. The change relies on Vector128, and in particular Vector128.LoadUnsafe, ShiftLeft, ShiftRight, and StoreUnsafe. Are those all appropriately optimized in whatever mono configuration this is? |
Not sure if they are optimized for mono interpreter. cc @BrzVlad |
Regression in change from |
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @BrzVlad Issue DetailsRun Information
Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Net.Primitives.Tests.IPAddressPerformanceTests*' PayloadsHistogramEdge Detector InfoSystem.Net.Primitives.Tests.IPAddressPerformanceTests.Ctor_Span(address: [16, 32, 48, 64, 80, ...])
Description of detection logic
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
|
Decided not to embark on these optimizations before having SSA. |
Run Information
Regressions in System.Net.Primitives.Tests.IPAddressPerformanceTests
Test Report
Repro
Payloads
Baseline
Compare
Histogram
Edge Detector Info
Collection Data
System.Net.Primitives.Tests.IPAddressPerformanceTests.Ctor_Span(address: [16, 32, 48, 64, 80, ...])
Description of detection logic
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: