Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc1: Performance regressions in CastingPerf benchmarks #75537

Closed
EgorBo opened this issue Sep 13, 2022 · 7 comments
Closed

rc1: Performance regressions in CastingPerf benchmarks #75537

EgorBo opened this issue Sep 13, 2022 · 7 comments
Assignees
@mrsharm
Labels
area-GC-coreclr tenet-performance Performance related issue
Milestone
8.0.0

Comments

@EgorBo
Copy link
Member

EgorBo commented Sep 13, 2022 •
edited
Loading

Various CastingPerf benchmarks regressed in RC1, e.g.

image

Namely:

Commit range: f58a790...01e2521
@EgorBo EgorBo added the tenet-performance Performance related issue label Sep 13, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 13, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Sep 13, 2022 •
edited
Loading

@jakobbotsch can it be #73562? the regression exists only on x64

Another candidates are GC-related changes: #73375 and #67389

@jakobbotsch
Copy link
Member

@jakobbotsch can it be #73562? the regression exists only on x64

I don't see how, that change should barely affect x64.

@ghost
Copy link

ghost commented Sep 14, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Various CastingPerf benchmarks regressed in RC1, e.g.

image

Namely:

Commit range: f58a790...01e2521

Author: EgorBo
Assignees: -
Labels:

tenet-performance, area-GC-coreclr, untriaged
Milestone: -

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Sep 15, 2022
@jeffschwMSFT jeffschwMSFT added this to the 7.0.0 milestone Sep 15, 2022
@EgorBo EgorBo mentioned this issue Sep 28, 2022
Closed
18 tasks
@mangod9
Copy link
Member

mangod9 commented Oct 3, 2022

I have verified that setting COMPlus_GCWriteBarrier=3 improves the perf here for wks. Since the precise write barrier has shown better perf for real world scenarios, we will continue to investigate this in 8.

@mangod9 mangod9 modified the milestones: 7.0.0, 8.0.0 Oct 4, 2022
@mangod9 mangod9 assigned mrsharm and unassigned PeterSolMS Aug 10, 2023
@mrsharm
Copy link
Member

mrsharm commented Aug 10, 2023

Closing - there seems to be a general improvement for these benchmarks:

image
https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04%2fPerfLabTests.CastingPerf.ObjFooIsObj2.html

@mrsharm mrsharm closed this as completed Aug 10, 2023
@MichalPetryka
Copy link
Contributor

Closing - there seems to be a general improvement for these benchmarks:

What's that big regression at the start of the chart there?

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrsharm mrsharm

Labels
area-GC-coreclr tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
7 participants
@EgorBo @jakobbotsch @jeffschwMSFT @PeterSolMS @MichalPetryka @mangod9 @mrsharm