Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with LoopbackServer for web sockets #73849

Open
greenEkatherine opened this issue Aug 12, 2022 · 1 comment
Open

Add tests with LoopbackServer for web sockets #73849

greenEkatherine opened this issue Aug 12, 2022 · 1 comment
Assignees
@CarnaViire
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Milestone
Future

Comments

@greenEkatherine
Copy link
Contributor

We should increase test scenarios for web sockets that are running with LoopbackServer -- first of all, for web sockets over HTTP/2 and then for HTTP/1.1.

Now many tests are running only in outerloop, which runs on request and not in every CI. This option is unavailable for web sockets over HTTP/2 because the external server has not yet supported it.

To achieve more test coverage, Http2LoopbackServer should be adapted to work with web sockets i.e., it should have a special stream wrapper to decode received data easily.
@greenEkatherine greenEkatherine added the test-enhancement Improvements of test source code label Aug 12, 2022
@greenEkatherine greenEkatherine self-assigned this Aug 12, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 12, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

We should increase test scenarios for web sockets that are running with LoopbackServer -- first of all, for web sockets over HTTP/2 and then for HTTP/1.1.

Now many tests are running only in outerloop, which runs on request and not in every CI. This option is unavailable for web sockets over HTTP/2 because the external server has not yet supported it.

To achieve more test coverage, Http2LoopbackServer should be adapted to work with web sockets i.e., it should have a special stream wrapper to decode received data easily.

Author: greenEkatherine
Assignees: greenEkatherine
Labels:

area-System.Net.Http, test-enhancement
Milestone: -

@greenEkatherine greenEkatherine mentioned this issue Aug 12, 2022
Merged
@greenEkatherine greenEkatherine removed the untriaged New issue has not been triaged by the area owner label Aug 12, 2022
@karelz karelz added this to the 8.0.0 milestone Aug 22, 2022
@greenEkatherine greenEkatherine mentioned this issue Aug 25, 2022
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 13, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 21, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 2, 2023
@karelz karelz modified the milestones: 8.0.0, Future Jun 9, 2023
@karelz karelz modified the milestones: Future, 9.0.0 Jul 18, 2023
@MihaZupan MihaZupan modified the milestones: 9.0.0, Future Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarnaViire CarnaViire

Labels
area-System.Net.Http test-enhancement Improvements of test source code
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Refactoring tests to support both external and loopback servers greenEkatherine/runtime
4 participants
@CarnaViire @karelz @greenEkatherine @MihaZupan