Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly.ReflectionOnlyLoad should throw PNSE #7273

Closed
jkotas opened this issue Jan 23, 2017 · 3 comments
Closed

Assembly.ReflectionOnlyLoad should throw PNSE #7273

jkotas opened this issue Jan 23, 2017 · 3 comments
Assignees
@rahku
Labels
area-System.Reflection
Milestone
2.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Jan 23, 2017

Reflection-only loads are not supported in CoreCLR. (FEATURE_REFLECTION_ONLY_LOAD)

Assembly.ReflectionOnlyLoad are doing full loads instead of reflection-only loads. They should throw PNSE instead.

The matching corefx tests should be updated: https://github.com/dotnet/corefx/blob/f9efc9625f795673c5c17d0791d8c79710a267b9/src/System.Runtime/tests/System/Reflection/AssemblyTests.cs#L161
@jkotas
Copy link
Member Author

jkotas commented Jan 23, 2017

Note that other ReflectionOnly APIs like AppDomain.ReflectionOnlyGetAssemblies() are doing the right thing already.

@jkotas
Copy link
Member Author

jkotas commented Jan 23, 2017

ReflectionOnlyGetType also - we do not seem to have any tests for it.

@rahku
Copy link
Contributor

rahku commented Feb 22, 2017

Fixed

@rahku rahku closed this as completed Feb 22, 2017
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rahku rahku

Labels
area-System.Reflection
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@jkotas @msftgits @rahku