Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateJsonPropertyInfo NullReferenceException #71296

Closed
JamesNK opened this issue Jun 26, 2022 · 2 comments · Fixed by #71324
Closed

CreateJsonPropertyInfo NullReferenceException #71296

JamesNK opened this issue Jun 26, 2022 · 2 comments · Fixed by #71324
Assignees
@krwq
Labels
area-System.Text.Json bug
Milestone
7.0.0

Comments

@JamesNK
Copy link
Member

JamesNK commented Jun 26, 2022

Description

CreateJsonPropertyInfo throws NRE when type is null.

cc @eiriktsarpalis

Reproduction Steps

JsonTypeInfo.CreateJsonPropertyInfo(null, "Name");

Expected behavior

ArgumentNullException

Actual behavior

NullReferenceException

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 26, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Text.Json and removed untriaged New issue has not been triaged by the area owner labels Jun 26, 2022
@ghost
Copy link

ghost commented Jun 26, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

CreateJsonPropertyInfo throws NRE when type is null.

cc @eiriktsarpalis

Reproduction Steps

JsonTypeInfo.CreateJsonPropertyInfo(null, "Name");

Expected behavior

ArgumentNullException

Actual behavior

NullReferenceException

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: JamesNK
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis
Copy link
Member

@krwq we might want to double check that all new public APIs validate null arguments

@krwq krwq added the bug label Jun 27, 2022
@krwq krwq added this to the 7.0.0 milestone Jun 27, 2022
@krwq krwq mentioned this issue Jun 27, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krwq krwq

Labels
area-System.Text.Json bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Argument tests for CreateJsonTypeInfo and CreateJsonPropertyInfo krwq/runtime-1
3 participants
@JamesNK @krwq @eiriktsarpalis