Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Numerics.Tests.Perf_Plane #70497

Closed
performanceautofiler bot opened this issue Jun 9, 2022 · 5 comments
Closed

Regressions in System.Numerics.Tests.Perf_Plane #70497

performanceautofiler bot opened this issue Jun 9, 2022 · 5 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jun 9, 2022

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 213b4d436ed58b9fb1bbf5e0667ea44df1f8c914
Compare bab1a1f239325746873d2ae795ea343e7901dbce
Diff Diff

Regressions in System.Numerics.Tests.Perf_Plane

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateFromVector4Benchmark - Duration of single invocation 14.05 ns 15.83 ns 1.13 0.57 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Numerics.Tests.Perf_Plane*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Plane.CreateFromVector4Benchmark


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 15.829495218029223 > 12.255039441035741.
IsChangePoint: Marked as a change because one of 3/22/2022 12:26:23 PM, 6/6/2022 8:15:49 PM, 6/9/2022 12:28:12 AM falls between 5/31/2022 10:47:41 AM and 6/9/2022 12:28:12 AM.
IsRegressionStdDev: Marked as regression because -9.159281745266673 (T) = (0 -18.97853846493613) / Math.Sqrt((1.4576871194799397 / (37)) + (4.132828696367864 / (8))) is less than -2.016692199226234 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (8) - 2, .025) and -0.5621637043335346 = (12.148879411478157 - 18.97853846493613) / 12.148879411478157 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

category:performance
theme:benchmarks

@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Jun 9, 2022
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Jun 9, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@DrewScoggins
Copy link
Member

Seems related to #70215

@DrewScoggins DrewScoggins changed the title [Perf] Changes at 6/7/2022 2:18:03 AM Regressions in System.Numerics.Tests.Perf_Plane Jun 9, 2022
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Jun 9, 2022
@danmoseley danmoseley added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 213b4d436ed58b9fb1bbf5e0667ea44df1f8c914
Compare bab1a1f239325746873d2ae795ea343e7901dbce
Diff Diff

Regressions in System.Numerics.Tests.Perf_Plane

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateFromVector4Benchmark - Duration of single invocation 14.05 ns 15.83 ns 1.13 0.57 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Numerics.Tests.Perf_Plane*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Plane.CreateFromVector4Benchmark


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 15.829495218029223 > 12.255039441035741.
IsChangePoint: Marked as a change because one of 3/22/2022 12:26:23 PM, 6/6/2022 8:15:49 PM, 6/9/2022 12:28:12 AM falls between 5/31/2022 10:47:41 AM and 6/9/2022 12:28:12 AM.
IsRegressionStdDev: Marked as regression because -9.159281745266673 (T) = (0 -18.97853846493613) / Math.Sqrt((1.4576871194799397 / (37)) + (4.132828696367864 / (8))) is less than -2.016692199226234 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (8) - 2, .025) and -0.5621637043335346 = (12.148879411478157 - 18.97853846493613) / 12.148879411478157 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: tannergooding
Labels:

tenet-performance, tenet-performance-benchmarks, area-CodeGen-coreclr, untriaged, refs/heads/main, ubuntu 18.04, RunKind=micro, Regression, CoreClr, arm64

Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 10, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jun 10, 2022
@tannergooding tannergooding modified the milestones: 7.0.0, 8.0.0 Jun 16, 2022
@tannergooding
Copy link
Member

Retargeting to .NET 8. We're emitting an extra instruction here but its not something that's high priority to fix.

@jeffhandley jeffhandley added arch-arm64 runtime-coreclr specific to the CoreCLR runtime and removed arm64 labels Dec 28, 2022
@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) and removed ubuntu 18.04 labels Dec 28, 2022
@BruceForstall BruceForstall removed arch-arm64 os-linux Linux OS (any supported distro) labels Jan 23, 2023
@tannergooding
Copy link
Member

tannergooding commented Jun 9, 2023

This is related to #70182 and #81766. Closing as it is better tracked by those issues.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

7 participants