Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.IO.Tests.Perf_RandomAccess #66465

Closed
performanceautofiler bot opened this issue Mar 10, 2022 · 4 comments
Closed

Regressions in System.IO.Tests.Perf_RandomAccess #66465

performanceautofiler bot opened this issue Mar 10, 2022 · 4 comments
Assignees
Labels
arch-arm64 area-System.Threading runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 10, 2022

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 20294957616061616e672b43f1d962460b7f4234
Compare eb57c1276add1ec7e35897bfdbbebb648839dee3
Diff Diff

Regressions in System.IO.Tests.Perf_RandomAccess

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ReadScatterAsync - Duration of single invocation 4.82 ms 5.16 ms 1.07 0.00 True

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.Perf_RandomAccess*'

Payloads

Baseline
Compare

Histogram

System.IO.Tests.Perf_RandomAccess.ReadScatterAsync(fileSize: 1048576, buffersSize: 16384, options: Asynchronous)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 5.163939665653496 > 5.0542304047888384.
IsChangePoint: Marked as a change because one of 3/4/2022 11:33:07 AM, 3/9/2022 10:55:02 PM falls between 3/1/2022 6:59:52 AM and 3/9/2022 10:55:02 PM.
IsRegressionStdDev: Marked as regression because -33.52572914974136 (T) = (0 -5232528.847938628) / Math.Sqrt((2003371671.5500438 / (19)) + (1359554745.640083 / (18))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (18) - 2, .025) and -0.0943228896693405 = (4781521.886579274 - 5232528.847938628) / 4781521.886579274 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Mar 10, 2022
@DrewScoggins DrewScoggins changed the title [Perf] Changes at 3/4/2022 10:59:19 PM Regressions in System.IO.Tests.Perf_RandomAccess Mar 10, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Mar 10, 2022
@DrewScoggins
Copy link
Member

Could be related to #64834

@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Mar 10, 2022
@ghost
Copy link

ghost commented Mar 11, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 20294957616061616e672b43f1d962460b7f4234
Compare eb57c1276add1ec7e35897bfdbbebb648839dee3
Diff Diff

Regressions in System.IO.Tests.Perf_RandomAccess

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ReadScatterAsync - Duration of single invocation 4.82 ms 5.16 ms 1.07 0.00 True

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.Perf_RandomAccess*'

Payloads

Baseline
Compare

Histogram

System.IO.Tests.Perf_RandomAccess.ReadScatterAsync(fileSize: 1048576, buffersSize: 16384, options: Asynchronous)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 5.163939665653496 > 5.0542304047888384.
IsChangePoint: Marked as a change because one of 3/4/2022 11:33:07 AM, 3/9/2022 10:55:02 PM falls between 3/1/2022 6:59:52 AM and 3/9/2022 10:55:02 PM.
IsRegressionStdDev: Marked as regression because -33.52572914974136 (T) = (0 -5232528.847938628) / Math.Sqrt((2003371671.5500438 / (19)) + (1359554745.640083 / (18))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (18) - 2, .025) and -0.0943228896693405 = (4781521.886579274 - 5232528.847938628) / 4781521.886579274 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Threading, tenet-performance, tenet-performance-benchmarks, untriaged, refs/heads/main, RunKind=micro, Windows 10.0.19041, Regression, CoreClr, arm64

Milestone: -

@jkotas jkotas added arch-arm64 and removed arm64 labels Mar 14, 2022
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2022
@mangod9 mangod9 added this to the 7.0.0 milestone Jul 6, 2022
@kouvel
Copy link
Member

kouvel commented Aug 8, 2022

Closing as duplicate of #67965

@kouvel kouvel closed this as completed Aug 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime and removed CoreClr labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Threading runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

6 participants